Repository navigation
Extended boxes no longer squeeze the price scale from off-screen - #104
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_90c96e50-8ba5-4043-a9bd-640e9c473ba9) |
|
All contributors have signed the CLA ✍️ ✅ |
Member
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DrawingSceneRenderer.priceRangetreated any box withextend != 'none'as visible everywhere on the time axis, so a box with a one-sided extension folded itstop/bottominto the autoscale of windows its painted part never reaches. An indicator keeping anextend.rightbox near the latest bars (a common order-block idiom) flattened the candles in every earlier window the moment the user scrolled back through history.lineCoversWindow):extend.rightcovers[left, +inf),extend.leftcovers(-inf, right],extend.bothstill covers every window, and unextended boxes keep the plain overlap test. Polylines and labels (always'none') and linefills (mapped to'both'/'none') are unaffected.test/drawing-extend-autoscale.test.tspin the coverage rules per extend direction (written failing first), and the changelog carries the fix under[Unreleased].Verification
extend.right); scrolling into earlier history squashed the candles before the fix and autoscales tightly after it, while windows the boxes genuinely cover still fold them into the scale.Note
Low Risk
Localized change to drawing autoscale geometry with regression tests; no auth, data, or API surface changes.
Overview
Extended Pine boxes now follow the same direction-aware autoscale rules as extended lines (v0.6.11):
DrawingSceneRenderer.priceRangeno longer treats anyextend != 'none'box as visible on the entire time axis.One-sided extensions only fold
top/bottominto the price scale when the visible bar window overlaps where the box is actually painted — anchor span plusextend.righttoward[left, ∞)orextend.lefttoward(-∞, right].extend.bothstill affects every window. Scrolling into history no longer flattens candles when anextend.rightorder-block box sits on the latest bars.Tests in
drawing-extend-autoscale.test.tslock in the per-direction coverage; the changelog documents the fix under[Unreleased].Reviewed by Cursor Bugbot for commit 25d69bd. Bugbot is set up for automated code reviews on this repo. Configure here.