fix(settings): add missing keybinding rows (#927)

# Summary

<!-- What does this PR change and why? Keep it short. -->
Add Settings rows for Jump to Start, Jump to End and Listening Party.

Fixes #828.

# Testing

<!-- List the commands you ran yourself and their output. For a good
first issue, run every command under "Done when". Example:
- cargo fmt --all
- cargo clippy --no-default-features --features telemetry,tui -- -D
warnings
- cargo test --no-default-features --features telemetry,tui
- cargo test (when you changed code behind a feature flag)
-->
- `cargo fmt --all`
- `cargo test --features gui`

# Additional notes

<!-- Screenshots for UI changes, breaking change callouts, or follow-up
work. -->

---
<sub>💬 Questions or want to chat with other contributors? Join the
[spotatui Discord](https://spotatui.com/discord).</sub>


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
<!-- coderabbit-ai-generated:v1 -->

## Summary by CodeRabbit

* **New Features**
* Jump to Start, Jump to End, and Listening Party can now be assigned
custom shortcuts in Settings > Keybindings.
* Jump to Start and Jump to End move to the first and last rows of a
list, respectively. The Listening Party shortcut opens its menu and is
available when a Spotify session is active.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: LargeModGames <84450916+LargeModGames@users.noreply.github.com>

Author: WaterWhisperer

CHANGELOG.md

@@ -43,6 +43,8 @@
 
 - **Saved Albums goes back to newest saved first on Default**: picking Default in the sort menu after another sort left the list in that order until the next refetch, because Default had no case in the sort. It now orders each page by when the album was saved, newest first, whatever the previous order was ([#817](https://github.com/LargeModGames/spotatui/issues/817)).
 
+- **Jump and Listening Party keys can be rebound in Settings**: the Keybindings tab now includes Jump to Start, Jump to End and Listening Party ([#828](https://github.com/LargeModGames/spotatui/issues/828)).
+
 - **`playback --repeat` now advances repeat modes** from Off to Context to Track instead of sending the current mode ([#816](https://github.com/LargeModGames/spotatui/issues/816)).
 
 - **Apple Music playlists show their real song counts** in the desktop app and the browser GUI: every playlist in Your Library, "All songs" included, said `0 songs`, because the count was never read from Music. It now is, one playlist at a time, which adds about 8 ms per playlist to loading the sidebar; a playlist whose count Music cannot read shows no number rather than a wrong 0 ([#891](https://github.com/LargeModGames/spotatui/issues/891)).

gui/src/bindings/SettingsStrings.ts

@@ -1354,8 +1354,14 @@
       "keys_jump_to_artist_album_name": "Jump to Artist",
       "keys_jump_to_context_description": "Jump to current playback context",
       "keys_jump_to_context_name": "Jump to Context",
+      "keys_jump_to_end_description": "Jump to the last row of the list",
+      "keys_jump_to_end_name": "Jump to End",
+      "keys_jump_to_start_description": "Jump to the first row of the list",
+      "keys_jump_to_start_name": "Jump to Start",
       "keys_like_track_description": "Toggle saved state for the currently playing track or episode",
       "keys_like_track_name": "Like Track",
+      "keys_listening_party_description": "Open the Listening Party menu",
+      "keys_listening_party_name": "Listening Party",
       "keys_lyrics_view_description": "Open lyrics view",
       "keys_lyrics_view_name": "Lyrics View",
       "keys_manage_devices_description": "Open the source and device picker",
@@ -3359,8 +3365,14 @@
       "keys_jump_to_artist_album_name": "前往艺人",
       "keys_jump_to_context_description": "前往当前播放所属列表",
       "keys_jump_to_context_name": "前往所属列表",
+      "keys_jump_to_end_description": "Jump to the last row of the list",
+      "keys_jump_to_end_name": "Jump to End",
+      "keys_jump_to_start_description": "Jump to the first row of the list",
+      "keys_jump_to_start_name": "Jump to Start",
       "keys_like_track_description": "切换当前播放曲目或单集的收藏状态",
       "keys_like_track_name": "喜欢曲目",
+      "keys_listening_party_description": "Open the Listening Party menu",
+      "keys_listening_party_name": "Listening Party",
       "keys_lyrics_view_description": "打开歌词视图",
       "keys_lyrics_view_name": "歌词视图",
       "keys_manage_devices_description": "打开音源和设备选择器",
@@ -5364,8 +5376,14 @@
       "keys_jump_to_artist_album_name": "前往藝人",
       "keys_jump_to_context_description": "前往目前播放所屬清單",
       "keys_jump_to_context_name": "前往所屬清單",
+      "keys_jump_to_end_description": "Jump to the last row of the list",
+      "keys_jump_to_end_name": "Jump to End",
+      "keys_jump_to_start_description": "Jump to the first row of the list",
+      "keys_jump_to_start_name": "Jump to Start",
       "keys_like_track_description": "切換目前播放曲目或單集的收藏狀態",
       "keys_like_track_name": "喜歡曲目",
+      "keys_listening_party_description": "Open the Listening Party menu",
+      "keys_listening_party_name": "Listening Party",
       "keys_lyrics_view_description": "開啟歌詞畫面",
       "keys_lyrics_view_name": "歌詞畫面",
       "keys_manage_devices_description": "開啟來源和裝置選擇器",

gui/src/bindings/strings.json

@@ -577,6 +577,20 @@ impl App {
             }
           }
         }
+        "keys.jump_to_start" => {
+          if let SettingValue::Key(v) = &setting.value {
+            if let Ok(key) = crate::core::user_config::parse_key_public(v.clone()) {
+              self.user_config.keys.jump_to_start = key;
+            }
+          }
+        }
+        "keys.jump_to_end" => {
+          if let SettingValue::Key(v) = &setting.value {
+            if let Ok(key) = crate::core::user_config::parse_key_public(v.clone()) {
+              self.user_config.keys.jump_to_end = key;
+            }
+          }
+        }
         "keys.toggle_playback" => {
           if let SettingValue::Key(v) = &setting.value {
             if let Ok(key) = crate::core::user_config::parse_key_public(v.clone()) {
@@ -689,6 +703,13 @@ impl App {
             }
           }
         }
+        "keys.listening_party" => {
+          if let SettingValue::Key(v) = &setting.value {
+            if let Ok(key) = crate::core::user_config::parse_key_public(v.clone()) {
+              self.user_config.keys.listening_party = key;
+            }
+          }
+        }
         "keys.decrease_volume" => {
           if let SettingValue::Key(v) = &setting.value {
             if let Ok(key) = crate::core::user_config::parse_key_public(v.clone()) {

src/core/app/settings_apply.rs

@@ -113,6 +113,7 @@ pub(crate) fn setting_requirement(id: &str) -> Requirement {
     | "keys.jump_to_album"
     | "keys.jump_to_artist_album"
     | "keys.jump_to_context"
+    | "keys.listening_party"
     | "keys.copy_song_url"
     | "keys.copy_album_url" => Requirement::SpotifySession,
     // The like key favorites the station under Radio.
@@ -888,6 +889,18 @@ impl App {
           description: strings.keys_previous_page_description.to_string(),
           value: SettingValue::Key(key_to_config_string(&self.user_config.keys.previous_page)),
         },
+        SettingItem {
+          id: "keys.jump_to_start".to_string(),
+          name: strings.keys_jump_to_start_name.to_string(),
+          description: strings.keys_jump_to_start_description.to_string(),
+          value: SettingValue::Key(key_to_config_string(&self.user_config.keys.jump_to_start)),
+        },
+        SettingItem {
+          id: "keys.jump_to_end".to_string(),
+          name: strings.keys_jump_to_end_name.to_string(),
+          description: strings.keys_jump_to_end_description.to_string(),
+          value: SettingValue::Key(key_to_config_string(&self.user_config.keys.jump_to_end)),
+        },
         SettingItem {
           id: "keys.toggle_playback".to_string(),
           name: strings.keys_toggle_playback_name.to_string(),
@@ -988,6 +1001,12 @@ impl App {
           description: strings.keys_manage_devices_description.to_string(),
           value: SettingValue::Key(key_to_config_string(&self.user_config.keys.manage_devices)),
         },
+        SettingItem {
+          id: "keys.listening_party".to_string(),
+          name: strings.keys_listening_party_name.to_string(),
+          description: strings.keys_listening_party_description.to_string(),
+          value: SettingValue::Key(key_to_config_string(&self.user_config.keys.listening_party)),
+        },
         SettingItem {
           id: "keys.decrease_volume".to_string(),
           name: strings.keys_decrease_volume_name.to_string(),
@@ -1423,6 +1442,51 @@ mod tests {
     );
   }
 
+  #[test]
+  fn keybinding_rows_show_jump_and_party_keys() {
+    let app = keybinding_rows_with_f5_help_and_home_search();
+    for (id, value) in [
+      ("keys.jump_to_start", "ctrl-a"),
+      ("keys.jump_to_end", "ctrl-e"),
+      ("keys.listening_party", "ctrl-p"),
+    ] {
+      assert_eq!(key_row(&app, id), SettingValue::Key(value.to_string()));
+    }
+  }
+
+  #[test]
+  fn editing_jump_and_party_rows_applies_the_new_keys() {
+    let mut app = keybinding_rows_with_f5_help_and_home_search();
+    for (id, value) in [
+      ("keys.jump_to_start", "f6"),
+      ("keys.jump_to_end", "f7"),
+      ("keys.listening_party", "f8"),
+    ] {
+      let item = app
+        .settings_items
+        .iter_mut()
+        .find(|item| item.id == id)
+        .unwrap();
+      item.value = SettingValue::Key(value.to_string());
+    }
+    app.apply_settings_changes();
+    assert_eq!(app.user_config.keys.jump_to_start, Key::F6);
+    assert_eq!(app.user_config.keys.jump_to_end, Key::F7);
+    assert_eq!(app.user_config.keys.listening_party, Key::F8);
+  }
+
+  #[test]
+  fn the_listening_party_key_row_needs_a_spotify_session() {
+    let mut app = keybinding_rows_with_f5_help_and_home_search();
+    let requirement = setting_requirement("keys.listening_party");
+    assert!(!app.availability(requirement).is_available());
+    assert!(offered(&app, "keys.listening_party"));
+    assert_eq!(setting_requirement("keys.jump_to_start"), Requirement::None);
+    assert_eq!(setting_requirement("keys.jump_to_end"), Requirement::None);
+    app.spotify_connected = true;
+    assert!(app.availability(requirement).is_available());
+  }
+
   #[test]
   fn every_key_row_parses_back_as_a_key() {
     let app = keybinding_rows_with_f5_help_and_home_search();

src/core/app/settings_schema.rs

@@ -162,6 +162,10 @@ pub struct SettingsStrings {
   pub keys_next_page_description: &'static str,
   pub keys_previous_page_name: &'static str,
   pub keys_previous_page_description: &'static str,
+  pub keys_jump_to_start_name: &'static str,
+  pub keys_jump_to_start_description: &'static str,
+  pub keys_jump_to_end_name: &'static str,
+  pub keys_jump_to_end_description: &'static str,
   pub keys_toggle_playback_name: &'static str,
   pub keys_toggle_playback_description: &'static str,
   pub keys_seek_backwards_name: &'static str,
@@ -194,6 +198,8 @@ pub struct SettingsStrings {
   pub keys_jump_to_context_description: &'static str,
   pub keys_manage_devices_name: &'static str,
   pub keys_manage_devices_description: &'static str,
+  pub keys_listening_party_name: &'static str,
+  pub keys_listening_party_description: &'static str,
   pub keys_decrease_volume_name: &'static str,
   pub keys_decrease_volume_description: &'static str,
   pub keys_increase_volume_name: &'static str,
@@ -661,6 +667,14 @@ impl SettingsStrings {
         self.keys_previous_page_name,
         self.keys_previous_page_description,
       ),
+      "keys.jump_to_start" => (
+        self.keys_jump_to_start_name,
+        self.keys_jump_to_start_description,
+      ),
+      "keys.jump_to_end" => (
+        self.keys_jump_to_end_name,
+        self.keys_jump_to_end_description,
+      ),
       "keys.toggle_playback" => (
         self.keys_toggle_playback_name,
         self.keys_toggle_playback_description,
@@ -710,6 +724,10 @@ impl SettingsStrings {
         self.keys_manage_devices_name,
         self.keys_manage_devices_description,
       ),
+      "keys.listening_party" => (
+        self.keys_listening_party_name,
+        self.keys_listening_party_description,
+      ),
       "keys.decrease_volume" => (
         self.keys_decrease_volume_name,
         self.keys_decrease_volume_description,

src/core/i18n/settings.rs

@@ -153,6 +153,10 @@ pub const EN: SettingsStrings = SettingsStrings {
   keys_next_page_description: "Navigate to next page",
   keys_previous_page_name: "Previous Page",
   keys_previous_page_description: "Navigate to previous page",
+  keys_jump_to_start_name: "Jump to Start",
+  keys_jump_to_start_description: "Jump to the first row of the list",
+  keys_jump_to_end_name: "Jump to End",
+  keys_jump_to_end_description: "Jump to the last row of the list",
   keys_toggle_playback_name: "Toggle Playback",
   keys_toggle_playback_description: "Play/pause",
   keys_seek_backwards_name: "Seek Backwards",
@@ -185,6 +189,8 @@ pub const EN: SettingsStrings = SettingsStrings {
   keys_jump_to_context_description: "Jump to current playback context",
   keys_manage_devices_name: "Switch Music Source",
   keys_manage_devices_description: "Open the source and device picker",
+  keys_listening_party_name: "Listening Party",
+  keys_listening_party_description: "Open the Listening Party menu",
   keys_decrease_volume_name: "Decrease Volume",
   keys_decrease_volume_description: "Decrease playback volume",
   keys_increase_volume_name: "Increase Volume",