Dukes-MacDonald tidy - #146
Open
alecloudenback wants to merge 1 commit into
Open
alecloudenback wants to merge 1 commit into
alecloudenback wants to merge 1 commit into
Conversation
Drop the unused self-import of SelectUltimateTable and route the three table-taking methods through one helper that reads the point-in-scale and select rates from the table. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JFnc6pvofuNXTW2xdCcewT
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor/10-exports-docs #146 +/- ##
===========================================================
Coverage ? 90.73%
===========================================================
Files ? 10
Lines ? 367
Branches ? 0
===========================================================
Hits ? 333
Misses ? 34
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dukes_macdonald.jlimportedSelectUltimateTablefrom the module that was in the middle of defining it, and the import was unused. The three table-adapter methods were the same three lines copied.Changes
_point_in_scale_and_select(table, issue_age, attained_age); the three table-taking methods are one-liners over it. Docstrings stay on the direct-argument methods.Testing
Stacked on #145 (base branch
refactor/10-exports-docs). Merge the stack in order; once the base PR is merged and its branch deleted, GitHub retargets this PR tomaster.🤖 Generated with Claude Code
https://claude.ai/code/session_01JFnc6pvofuNXTW2xdCcewT