Fix TSX Badge URL Extraction in ExportPanel - #8907
Conversation
|
@tamilr0727-ux is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This PR addresses badge download failures by improving the URL extraction logic for TSX formats, ensuring compatibility with various snippet types. It also includes regression tests to maintain existing functionality. This aligns with our previous decisions to enhance testing and ensure robust handling of different formats. Thank you for your contributions! |
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
Aamod007
left a comment
There was a problem hiding this comment.
Excellent fix for the TSX Badge URL extraction! Mocking \URL.createObjectURL\ properly in JSDOM tests is crucial for testing the download functionality. Approved!
|
🎉 Congratulations @tamilr0727-ux! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
Description
Fixes badge download failures in
ExportPanel.tsxwhen the export format is set to TSX by improving badge URL extraction to support all supported snippet formats.Changes
Validation
Implemented tests covering:
Verification
✅
vitest runpasses successfully.✅ Badge downloads work correctly for Markdown, HTML, and TSX export formats.
✅ Existing download functionality remains unchanged for previously supported formats.
Fixes #8769
Pillar
Visual Preview
Can Check in the Files Changed Section.
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.