Report Work

[JAGarcia03]

Hello Chris,

Is there a way to look at the code that was added to the pull request that was closed? I want to add it to my report.

Thanks
Jose`

[chrisjonesBSU]

mosdef-hub/gmso#936

Follow that link and click the Files Changed tab. All new code is in green, any removed code is in red.

This is the still-in-progress PR to add the slicing and charge calculate methods: mosdef-hub/gmso#961

[JAGarcia03]

This is all the green I can see. I was looking more for the code that we added so I can compare it to the function the user would use to compare code length

[chrisjonesBSU]

https://github.com/mosdef-hub/gmso/pull/961/files

The green there shows all the new code that is part of the final PR. It's a lot, but from the user's perspective all of this is executed in one line of code. Something like:

topology.calculate_charges(method="am1bcc")

[chrisjonesBSU]

So, the point to make, is because of this PR and writing the code so that it is general and transferable to other systems, all of these steps can be reproducibly ran each time this one line of code is called (the one above). This is a significant upgrade over users handling all of this stuff on their own for each system.