Skip to content

Improve multi-partition accumulator flush assertions #811

Description

@coderabbitai

Summary

Improve the multi-partition coverage in test/accumulator_test.cpp.

The current test is sufficient to detect plausible failures because it checks distinct results from two partition caches. This follow-up should improve failure localization.

Required changes

  • Before each flush, assert the expected number of active accumulator cache entries.
  • Send each partition flush separately.
  • After each individual flush, assert the expected emitted result count, received result count, result value, and cache state.

Rationale

The additional assertions will show whether a failure occurs during cache creation, flush processing, or result emission. This change is non-blocking for PR #540.

Affected area

  • test/accumulator_test.cpp
  • The multi-partition accumulator test

Acceptance criteria

  • The multi-partition test checks cache state before flushing.
  • The test flushes one partition at a time.
  • The test verifies the result and cache state after each flush.
  • The test continues to verify independent results for both partitions.

References

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions