Could we get a way to use user-provided highlight.js definitions instead of just the standard ones?

[haltman-at]

So, I want to use chromafi to provide highlighting for Solidity. Now, Solidity is not presently in highlight.js (it likely soon will be, but I don't know how soon, and I have good reason to want this quickly and not have to wait there).

Fortunately, I can highlight Solidity with highlight.js by means of the highlightjs-solidity project, allowing me to register Solidity with my hljs object. Unfortunately, I have no way to use this in chromafi, since chromafi doesn't allow using a custom hljs object that might have additional languages registered.

I see two possible ways of remedying this:

1. Provide some way for the user to pass in a custom hljs object, on which they might have registered additional languages (or made other changes -- maybe they want custom highlighting for one of the standard languages!).
2. Don't allow that, but instead expose as exports some of what are currently purely internal functions, so that the user can, on their own, use their custom hljs object to get the XML-based highlighting, and then can pass the result into these lower-level functions you've now exposed, to achieve the same result.

(And maybe there's some other way I've failed to think of.)

In any case, any way of allowing the user to not be limited to hljs's current built-in languages would be appreciated. Thank you!

[F1LT3R]

Do you have an example of how your are extending hljs already?

[haltman-at]

Sure. Like I said, I'm using highlightjs-solidity.

In more detail, the way that works is that it exports a function, hljsDefineSolidity. You import hljs, you import hljsDefineSolidity, you call hljsDefineSolidity(hljs) and it registers Solidity on your hljs object and now you can use that object for Solidity highlighting.

Does that answer your question or do you still need more information?

[haltman-at]

Hey, since you never replied to the previous comment, I just thought I should check whether you still needed more clarification here.

Btw, it occurs to me that actually there is a third approach: You could somehow expose the hljs object you're using, allowing the user to do things like register languages on it.

Anyway, hope that's helpful, once again let me know if more clarification is needed!

[haltman-at]

FWIW, my understanding (though I may be mistaken) is that highlightjs may be moving more in general to the model of adding new languages as separate add-ons, rather than including them buit-in in hljs, so that's another good reason to do this.