Fix cross-server shutdown countdown system - #1962
duckymomo360 wants to merge 1 commit into
Conversation
|
There's a small bug in this but I'm not sure how to fix it. It's either a command parser bug or something I'm misunderstanding. If you put the "reason" argument in quotes (so you can put a space in your reason), the args passed to the function get messed up in an unexpected way. When I run When I run Which doesn't make any sense. Does anyone know what's going on here? |
Yeah this is an issue with how adonis handles args when you specifically use quotes |
|
Adonis runs on diesel? |
Diesel is the name of our studio's private fork. I've been opening PRs for some of our fixes. And yes the studio's name is satirical |
|
Far better fixes were implemented in #1874 lolz |
For some reason the ;globalsoftshutdown command function parsed & validated the time parameter, but it didn't do anything further with it. The logic for it was already implemented but it was filled with issues. A lot of small fixes were required. Seems like it was like this since it was added. I'm guessing it was never properly tested...? Either way, this PR fixes it and makes this feature fully functional.
Recording.2025-08-19.232329.mp4