Skip to content

Fix cross-server shutdown countdown system - #1962

Closed
duckymomo360 wants to merge 1 commit into
Epix-Incorporated:masterfrom
duckymomo360:fix-cross-shutdown-countdown
Closed

duckymomo360 wants to merge 1 commit into
Epix-Incorporated:masterfrom
duckymomo360:fix-cross-shutdown-countdown

Conversation

@duckymomo360

@duckymomo360 duckymomo360 commented Aug 20, 2025 •

Copy link
Copy Markdown
Contributor

For some reason the ;globalsoftshutdown command function parsed & validated the time parameter, but it didn't do anything further with it. The logic for it was already implemented but it was filled with issues. A lot of small fixes were required. Seems like it was like this since it was added. I'm guessing it was never properly tested...? Either way, this PR fixes it and makes this feature fully functional.

Recording.2025-08-19.232329.mp4

@duckymomo360

duckymomo360 commented Aug 22, 2025 •

Copy link
Copy Markdown
Contributor Author

There's a small bug in this but I'm not sure how to fix it. It's either a command parser bug or something I'm misunderstanding.

If you put the "reason" argument in quotes (so you can put a space in your reason), the args passed to the function get messed up in an unexpected way.
I added this simple test print to the start of the GlobalSoftShutdown function:
for _, v in args do print(v) end

When I run ;globalsoftshutdown reason 10m false
I get the output:

reason
10m
false

When I run ;globalsoftshutdown "reason quoted" 10m false
I get the output:

reason quoted
10m
m false

Which doesn't make any sense.
Basically; if you want to put space in your "reason" argument, the "abortable" argument will become malformed, and the argument will be forced to fallback to it's default (true).

Does anyone know what's going on here?

@WalkerOfBacon

Copy link
Copy Markdown
Contributor

When I run ;globalsoftshutdown "reason quoted" 10m false I get the output:

reason quoted
10m
m false

Which doesn't make any sense. Basically; if you want to put space in your "reason" argument, the "abortable" argument will become malformed, and the argument will be forced to fallback to it's default (true).

Does anyone know what's going on here?

Yeah this is an issue with how adonis handles args when you specifically use quotes
A fix was attempted but its no use (needs a entire rewrite imo)

@GalacticInspired

Copy link
Copy Markdown
Member

Adonis runs on diesel?

@duckymomo360

duckymomo360 commented Aug 27, 2025 •

Copy link
Copy Markdown
Contributor Author

Adonis runs on diesel?

Diesel is the name of our studio's private fork. I've been opening PRs for some of our fixes. And yes the studio's name is satirical

@Dimenpsyonal Dimenpsyonal added 🐛 bug Bugs or broken features ✨ enhancement Enhancing or improving existing functionality labels Sep 1, 2025
@duckymomo360

Copy link
Copy Markdown
Contributor Author

Far better fixes were implemented in #1874 lolz

@duckymomo360
duckymomo360 deleted the fix-cross-shutdown-countdown branch October 2, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Bugs or broken features ✨ enhancement Enhancing or improving existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants