Repository navigation
Keep the signer webview on the signer page - #223
Open
tomas-martins-crossmint wants to merge 2 commits into
Open
tomas-martins-crossmint wants to merge 2 commits into
tomas-martins-crossmint wants to merge 2 commits into
Conversation
Contributor
[Medium impact] The changes appear safe to merge. Reviews (2) · Last reviewed commit: "Test signer navigation through WebKit an..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes the signer webview trust only the signer page it loaded. Messages from iframes or from any other origin are dropped, and the page can't navigate away from the signer origin
The signer page has no iframes and never navigates, so apps see no difference. The trusted origin comes from the URL the SDK loads, so production and staging both work with no list to keep up to date
Changes
DefaultWebViewCommunicationProxyhandles a message only when it comes from the main frame and the origin of the loaded URLwebView(_:decidePolicyFor:decisionHandler:)allows main frame navigation only within that originsigner.message.droppedand blocked navigations logsigner.navigation.blocked