Repository navigation
Conversation
|
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 2044fba. Configure here.
Author
|
Removed the generated changelog placeholder so the fragment now contains only the release note for #705. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
X-ClickHouse-Exception-Codeas a server error even when progress headers leave the HTTP status at 200.InsertBinaryAsyncand a changelog fragment.Fixes #705
Validation
dotnet run scripts/changelog.cs -- --checkpassed.Note
Medium Risk
Central HTTP error handling changed for all callers of
HandleError, including inserts and queries; behavior is more strict but aligns with server semantics and prevents silent insert failures.Overview
Fixes a case where binary inserts (and other operations using
HandleError) could succeed even though ClickHouse failed after streaming progress headers—the HTTP status stays 200 whileX-ClickHouse-Exception-Codecarries the real failure.HandleErrornow treats any response with that header as an error, not only non-2xx statuses. When the body is non-empty, the thrownClickHouseServerExceptionuses the header value asErrorCodewhen present; empty-body paths get clearer messaging for “exception reported with HTTP 200.”Tests add
InsertBinaryAsyncregression coverage and extend the empty-body + header test toHttpStatusCode.OKas well as 503. Changelog fragment for #705.Reviewed by Cursor Bugbot for commit 40850ae. Bugbot is set up for automated code reviews on this repo. Configure here.