From d04c3af63c1775ae8c05dc2bd20300e7be531272 Mon Sep 17 00:00:00 2001 From: Amaad Martin Date: Sun, 2 Aug 2026 02:44:38 -0700 Subject: [PATCH] Fix: drop the unresolvable @google/adk subpath imports from the Vertex AI session service test The core package's exports map declares only the "." subpath, so '@google/adk/sessions/session.js', '@google/adk/sessions/vertex_ai_session_service.js' and '@google/adk/utils/logger.js' resolve for nobody: not for tsc under moduleResolution nodenext, and not for Node. They appeared to work only because the vitest config aliases the '@google/adk' prefix onto core/src, which turns a deep specifier into a plain path into the source tree. Point each import at a specifier that is actually valid. Session is public (core/src/common.ts exports it), so it joins the existing '@google/adk' import. isVertexAiConnectionString, quoteFilterLiteral and logger are internal, so they use the relative path into src that the other 155 core/test imports already use. --- core/test/sessions/vertex_ai_session_service_test.ts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/core/test/sessions/vertex_ai_session_service_test.ts b/core/test/sessions/vertex_ai_session_service_test.ts index c0e834607..7f2048e02 100644 --- a/core/test/sessions/vertex_ai_session_service_test.ts +++ b/core/test/sessions/vertex_ai_session_service_test.ts @@ -5,8 +5,7 @@ */ import {Sessions} from '@google-cloud/vertexai/build/src/genai/sessions.js'; -import {createEvent, State, VertexAiSessionService} from '@google/adk'; -import {Session} from '@google/adk/sessions/session.js'; +import {createEvent, Session, State, VertexAiSessionService} from '@google/adk'; import {ApiError} from '@google/genai'; import {beforeEach, describe, expect, it, vi} from 'vitest'; @@ -24,8 +23,8 @@ vi.mock('nodejs-vertexai', () => ({ import { isVertexAiConnectionString, quoteFilterLiteral, -} from '@google/adk/sessions/vertex_ai_session_service.js'; -import {logger} from '@google/adk/utils/logger.js'; +} from '../../src/sessions/vertex_ai_session_service.js'; +import {logger} from '../../src/utils/logger.js'; describe('isVertexAiConnectionString', () => { it('returns true for vertexai://', () => {