test: SharedState collective save-failure rollback (PRPUNDIT-8, PRPUNDIT-9) - #1324
Merged
Conversation
…IT-8) Force SharedState.save to fail and assert in-memory last_collective/collective_attempts and state.json are unchanged.
Force SharedState.save to fail and assert in-memory last_collective/collective_attempts and state.json are unchanged.
Keep both SharedState save-failure rollback tests in one file so the pair can land without a conflict.
Collaborator
Author
1 task
jiagaoxiang
changed the title
zoroyihan7
approved these changes
Aug 31, 2026
zoroyihan7
left a comment
zoroyihan7
left a comment
Contributor
There was a problem hiding this comment.
Reviewed with an independent verification pass: ran the touched test file on this branch and mutation-tested the production code to confirm the new tests actually catch regressions (not just pass).
Mutations tried and caught: deleting the restore lines in record_collective and in record_collective_integration each turns the corresponding new test red, so both producers are pinned separately.
No regressions in the surrounding suite (pre-existing failures verified identical on origin/main). LGTM.
zoroyihan7
enabled auto-merge (squash)
August 31, 2026 07:41
Contributor
|
/retest (e2e failed on the |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SharedState.saveto fail duringrecord_collectiveandrecord_collective_integration.last_collective/collective_attemptsrestore and on-diskstate.jsonis unchanged.Covers test gaps PRPUNDIT-8 and PRPUNDIT-9 (merged from #1323 into this PR).
Test plan
PYTHONPATH=src pytest src/hyperloom/inference_optimizer/tests/test_collective_lane.py::test_record_collective_rolls_back_when_save_fails src/hyperloom/inference_optimizer/tests/test_collective_lane.py::test_record_collective_integration_rolls_back_when_save_fails