fix(jsonrpc): drop data from 4444 and remove ResultCodeUtil

- 4444 no longer carries the earliest available block in data, as geth
- remove ResultCodeUtil; constant calls record only REVERT

Author: 0xbigapple

chainbase/src/main/java/org/tron/core/ChainBaseManager.java

@@ -248,7 +248,6 @@ public class ChainBaseManager {
 
   // lowest block with receipts; above lowestBlockNum on a LiteNode
   @Getter
-  @Setter
   private long lowestReceiptBlockNum = -1;
 
   @Getter

chainbase/src/main/java/org/tron/core/store/TransactionRetStore.java

@@ -2,7 +2,6 @@
 
 import com.google.common.primitives.Longs;
 import com.google.protobuf.ByteString;
-import java.util.Map;
 import java.util.Objects;
 import java.util.OptionalLong;
 import lombok.extern.slf4j.Slf4j;
@@ -48,13 +47,8 @@ public void put(byte[] key, TransactionRetCapsule item) {
    * layers, {@code getNext} does not merge deletions correctly.
    */
   public OptionalLong getLowestBlockNum() {
-    Map<byte[], byte[]> entries = revokingDB.getNext(ByteArray.fromLong(0), 1);
-    for (byte[] key : entries.keySet()) {
-      if (key.length == Long.BYTES) {
-        return OptionalLong.of(Longs.fromByteArray(key));
-      }
-    }
-    return OptionalLong.empty();
+    return revokingDB.getNext(ByteArray.fromLong(0), 1).keySet().stream()
+        .mapToLong(Longs::fromByteArray).findFirst();
   }
 
   public TransactionInfoCapsule getTransactionInfo(byte[] key) throws BadItemException {

common/src/main/java/org/tron/core/exception/jsonrpc/JsonRpcPrunedHistoryException.java

@@ -1,9 +1,9 @@
 package org.tron.core.exception.jsonrpc;
 
 /**
- * Thrown when a request targets historical state that a LiteNode has pruned.
- * Maps to JSON-RPC error code 4444 "Pruned history unavailable", as standardized
- * by the Ethereum Execution API (EIP-4444).
+ * Thrown when a request targets data the node does not have: history pruned on a LiteNode,
+ * or receipts and logs on a node that does not persist them. Maps to JSON-RPC error code 4444
+ * "Pruned history unavailable", as standardized by the Ethereum Execution API (EIP-4444).
  */
 public class JsonRpcPrunedHistoryException extends JsonRpcException {
 

framework/src/main/java/org/tron/core/Wallet.java

@@ -201,7 +201,6 @@
 import org.tron.core.store.StoreFactory;
 import org.tron.core.store.VotesStore;
 import org.tron.core.store.WitnessStore;
-import org.tron.core.utils.ResultCodeUtil;
 import org.tron.core.utils.TransactionUtil;
 import org.tron.core.vm.config.VMConfig;
 import org.tron.core.vm.program.Program;
@@ -3200,8 +3199,6 @@ public Transaction callConstantContract(TransactionCapsule trxCap,
     ret.setStatus(0, code.SUCESS);
     if (StringUtils.isNoneEmpty(result.getRuntimeError())) {
       ret.setStatus(0, code.FAILED);
-      // same failure classification as executed transactions
-      ret.setResultCode(ResultCodeUtil.resolve(result.getException()));
       retBuilder
           .setMessage(ByteString.copyFromUtf8(result.getRuntimeError()))
           .build();

framework/src/main/java/org/tron/core/services/jsonrpc/JsonRpcApiUtil.java

@@ -704,7 +704,7 @@ public static long parseBlockNumber(String blockNumOrTag, Wallet wallet)
 
   /**
    * The lowest block for which everything the node persists is available; what "earliest"
-   * resolves to and what a 4444 error carries in {@code data}. On a LiteNode this is the
+   * resolves to. On a LiteNode this is the
    * receipt floor when receipts are persisted, otherwise the body floor (receipt endpoints
    * answer 4444 on such a node regardless of this value). On a FullNode it is genesis.
    */
@@ -723,7 +723,7 @@ public static long earliestAvailableBlock(Wallet wallet) {
   public static void checkPrunedHistory(long blockNum, Wallet wallet)
       throws JsonRpcPrunedHistoryException {
     if (wallet.isLiteNode() && blockNum < wallet.getLowestBlockNum()) {
-      throw prunedHistory(earliestAvailableBlock(wallet));
+      throw new JsonRpcPrunedHistoryException(PRUNED_HISTORY_ERROR);
     }
   }
 
@@ -736,21 +736,9 @@ public static void checkPrunedHistory(long blockNum, Wallet wallet)
   public static void checkPrunedReceiptHistory(long blockNum, Wallet wallet)
       throws JsonRpcPrunedHistoryException {
     long receiptFloor = wallet.getLowestReceiptBlockNum();
-    if (receiptFloor == Long.MAX_VALUE) {
+    if (receiptFloor == Long.MAX_VALUE || wallet.isLiteNode() && blockNum < receiptFloor) {
       throw new JsonRpcPrunedHistoryException(PRUNED_HISTORY_ERROR);
     }
-    if (wallet.isLiteNode() && blockNum < receiptFloor) {
-      throw prunedHistory(receiptFloor);
-    }
-  }
-
-  /**
-   * The Execution API fixes the message verbatim; the earliest available block travels in
-   * {@code data} so a client can pick a fallback node from it.
-   */
-  private static JsonRpcPrunedHistoryException prunedHistory(long earliestAvailable) {
-    return new JsonRpcPrunedHistoryException(PRUNED_HISTORY_ERROR,
-        "0x" + Long.toHexString(earliestAvailable));
   }
 
   /**

framework/src/main/java/org/tron/core/services/jsonrpc/TronJsonRpcImpl.java

@@ -934,6 +934,7 @@ private TransactionContext findTransactionContext(TransactionInfoList infoList,
    * @return List of TransactionReceipt objects for all transactions in the block,
    * null if block not found
    * @throws JsonRpcInvalidParamsException if the parameter format is invalid
+   * @throws JsonRpcPrunedHistoryException if the node does not have the block's receipts
    * @throws JsonRpcInternalException if there's an internal error
    */
   @Override
@@ -950,14 +951,13 @@ public List<TransactionReceipt> getBlockReceipts(String blockNumOrHashOrTag)
       block = getBlockByNumOrTag(blockNumOrHashOrTag);
     }
 
-    // block receipts not available: block is genesis, not produced yet, or pruned in light node
+    // block receipts not available: block is genesis, not produced yet, or unknown hash
     if (block == null || block.getBlockHeader().getRawData().getNumber() == 0) {
       return null;
     }
 
     BlockCapsule blockCapsule = new BlockCapsule(block);
     long blockNum = blockCapsule.getNum();
-    int transactionSizeInBlock = blockCapsule.getTransactions().size();
     // below the receipt floor the body exists but the receipts do not — 4444, not -32000
     JsonRpcApiUtil.checkPrunedReceiptHistory(blockNum, wallet);
     TransactionInfoList transactionInfoList = wallet.getTransactionInfoByBlockNum(blockNum);
@@ -966,6 +966,7 @@ public List<TransactionReceipt> getBlockReceipts(String blockNumOrHashOrTag)
     long energyFee = wallet.getEnergyFee(blockCapsule.getTimeStamp());
 
     // Validate transaction list size consistency
+    int transactionSizeInBlock = blockCapsule.getTransactions().size();
     if (transactionSizeInBlock != transactionInfoList.getTransactionInfoCount()) {
       throw new JsonRpcInternalException(
           String.format("TransactionList size mismatch: "

framework/src/main/java/org/tron/core/utils/ResultCodeUtil.java

@@ -29,7 +29,6 @@ public class JsonRpcPrunedHistoryTest {
   private static final long RECEIPT_FLOOR_BLOCK_NUM = 150L;
   private static final long HEAD_BLOCK_NUM = 200L;
   private static final String PRUNED_MESSAGE = "Pruned history unavailable";
-  private static final String BODY_FLOOR_HEX = "0x64";
   private static final String BELOW_CUTOFF_HEX = "0x10";
   private static final String AT_CUTOFF_HEX = "0x64";
   private static final long IN_RECEIPT_GAP_NUM = 112L;
@@ -101,18 +100,7 @@ public void testGetBlockByNumberBelowCutoffReturns4444() {
     JsonRpcPrunedHistoryException e = assertThrows(JsonRpcPrunedHistoryException.class,
         () -> liteRpc.ethGetBlockByNumber(BELOW_CUTOFF_HEX, false));
     Assert.assertEquals(PRUNED_MESSAGE, e.getMessage());
-    // data carries the same height "earliest" resolves to, not the endpoint's own floor
-    Assert.assertEquals(RECEIPT_FLOOR_HEX, e.getData());
-  }
-
-  @Test
-  public void testGetBlockByNumberBelowCutoffWithHistoryOffReportsBodyFloor() {
-    rpc = new TronJsonRpcImpl(mock(NodeInfoService.class), newHistoryOffMockWallet());
-
-    JsonRpcPrunedHistoryException e = assertThrows(JsonRpcPrunedHistoryException.class,
-        () -> rpc.ethGetBlockByNumber(BELOW_CUTOFF_HEX, false));
-    Assert.assertEquals(PRUNED_MESSAGE, e.getMessage());
-    Assert.assertEquals(BODY_FLOOR_HEX, e.getData());
+    Assert.assertNull(e.getData());
   }
 
   @Test
@@ -167,7 +155,7 @@ public void testGetBlockTransactionCountBelowCutoffReturns4444() {
     JsonRpcPrunedHistoryException e = assertThrows(JsonRpcPrunedHistoryException.class,
         () -> liteRpc.ethGetBlockTransactionCountByNumber(BELOW_CUTOFF_HEX));
     Assert.assertEquals(PRUNED_MESSAGE, e.getMessage());
-    Assert.assertEquals(RECEIPT_FLOOR_HEX, e.getData());
+    Assert.assertNull(e.getData());
   }
 
   @Test
@@ -177,7 +165,7 @@ public void testGetTransactionByBlockNumberAndIndexBelowCutoffReturns4444() {
     JsonRpcPrunedHistoryException e = assertThrows(JsonRpcPrunedHistoryException.class,
         () -> liteRpc.getTransactionByBlockNumberAndIndex(BELOW_CUTOFF_HEX, "0x0"));
     Assert.assertEquals(PRUNED_MESSAGE, e.getMessage());
-    Assert.assertEquals(RECEIPT_FLOOR_HEX, e.getData());
+    Assert.assertNull(e.getData());
   }
 
   @Test
@@ -187,18 +175,15 @@ public void testGetBlockReceiptsBelowCutoffReturns4444() {
     JsonRpcPrunedHistoryException e = assertThrows(JsonRpcPrunedHistoryException.class,
         () -> liteRpc.getBlockReceipts(BELOW_CUTOFF_HEX));
     Assert.assertEquals(PRUNED_MESSAGE, e.getMessage());
-    Assert.assertEquals(RECEIPT_FLOOR_HEX, e.getData());
+    Assert.assertNull(e.getData());
   }
 
   @Test
-  public void testGetBlockReceiptsBelowCutoffWithHistoryOffReportsBodyFloor() {
-    // with receipts never persisted, "earliest" falls back to the body floor and so does data
+  public void testGetBlockReceiptsFutureBlockWithHistoryOffReturnsNull() throws Exception {
+    // a block that does not exist yet is not pruned history
     rpc = new TronJsonRpcImpl(mock(NodeInfoService.class), newHistoryOffMockWallet());
 
-    JsonRpcPrunedHistoryException e = assertThrows(JsonRpcPrunedHistoryException.class,
-        () -> rpc.getBlockReceipts(BELOW_CUTOFF_HEX));
-    Assert.assertEquals(PRUNED_MESSAGE, e.getMessage());
-    Assert.assertEquals(BODY_FLOOR_HEX, e.getData());
+    Assert.assertNull(rpc.getBlockReceipts("0x7fffffff"));
   }
 
   @Test
@@ -209,7 +194,7 @@ public void testGetLogsFromBlockBelowCutoffReturns4444() {
     JsonRpcPrunedHistoryException e = assertThrows(JsonRpcPrunedHistoryException.class,
         () -> liteRpc.getLogs(fr));
     Assert.assertEquals(PRUNED_MESSAGE, e.getMessage());
-    Assert.assertEquals(RECEIPT_FLOOR_HEX, e.getData());
+    Assert.assertNull(e.getData());
   }
 
   @Test
@@ -220,7 +205,7 @@ public void testNewFilterFromBlockBelowCutoffReturns4444() {
     JsonRpcPrunedHistoryException e = assertThrows(JsonRpcPrunedHistoryException.class,
         () -> liteRpc.newFilter(fr));
     Assert.assertEquals(PRUNED_MESSAGE, e.getMessage());
-    Assert.assertEquals(RECEIPT_FLOOR_HEX, e.getData());
+    Assert.assertNull(e.getData());
   }
 
   @Test
@@ -273,7 +258,7 @@ public void testGetLogsInReceiptGapReturns4444() {
     JsonRpcPrunedHistoryException e = assertThrows(JsonRpcPrunedHistoryException.class,
         () -> liteRpc.getLogs(fr));
     Assert.assertEquals(PRUNED_MESSAGE, e.getMessage());
-    Assert.assertEquals(RECEIPT_FLOOR_HEX, e.getData());
+    Assert.assertNull(e.getData());
   }
 
   @Test
@@ -286,12 +271,12 @@ public void testGetBlockReceiptsInReceiptGapReturns4444() {
     JsonRpcPrunedHistoryException e = assertThrows(JsonRpcPrunedHistoryException.class,
         () -> rpc.getBlockReceipts(IN_RECEIPT_GAP_HEX));
     Assert.assertEquals(PRUNED_MESSAGE, e.getMessage());
-    Assert.assertEquals(RECEIPT_FLOOR_HEX, e.getData());
+    Assert.assertNull(e.getData());
   }
 
   @Test
   public void testGetBlockReceiptsEmptyBlockInReceiptGapReturns4444() {
-    // the floor is checked before the body is read, so an empty block is not special-cased
+    // the floor check ignores the transaction count, so an empty block is not special-cased
     Wallet wallet = newMockWallet(true);
     when(wallet.getBlockByNum(IN_RECEIPT_GAP_NUM))
         .thenReturn(newBlock(IN_RECEIPT_GAP_NUM, 0));
@@ -300,7 +285,7 @@ public void testGetBlockReceiptsEmptyBlockInReceiptGapReturns4444() {
     JsonRpcPrunedHistoryException e = assertThrows(JsonRpcPrunedHistoryException.class,
         () -> rpc.getBlockReceipts(IN_RECEIPT_GAP_HEX));
     Assert.assertEquals(PRUNED_MESSAGE, e.getMessage());
-    Assert.assertEquals(RECEIPT_FLOOR_HEX, e.getData());
+    Assert.assertNull(e.getData());
   }
 
   @Test